I want to mod a page from a site that prefixes all its links with "/?" I tried this:

links = getElementsByTagName('a');
for (l in links) {
    l.href = l.href.replace('/?','');
}

But it doesn't work. What am I doing wrong?

I want to mod a page from a site that prefixes all its links with "http://linkblur./?" I tried this:

links = getElementsByTagName('a');
for (l in links) {
    l.href = l.href.replace('http://linkblur./?','');
}

But it doesn't work. What am I doing wrong?

• javascript
• greasemonkey

2 Answers 2

Try:

var links = document.links;
var link;
for(var i=links.length-1; i >=0; i--){
  link = links[i];
  link.href = link.href.replace("http://linkblur./?", '');
}

You for iterator iterates over all the properties of your array, which will not be the individual items, but rather, 0, 1, 2, ..., n, length.

You want to change your iterator, and if you want to prefix the links, you're doing that wrong, too. What you're currently doing will replace linkblur.... with an empty string, i.e. remove linkblur from existing links.

var links = document.getElementsByTagName('a');
for (var i = 0; i < links.length; i++) {
    links[i].href = 'http://linkblur./?' + links[i].href;
}